Update a number of only_if conditionals.

playbooks/groups/badges-backend.yml

@@ -43,7 +43,7 @@
   - include: $tasks/motd.yml
   - include: $tasks/sudo.yml
   - include: $tasks/openvpn_client.yml
-    only_if: "'$env' != 'staging'"
+    when: env != "staging"
   - include: $tasks/fedmsg_base.yml
 
   handlers:

playbooks/groups/badges-web.yml

@@ -44,7 +44,7 @@
   - include: $tasks/motd.yml
   - include: $tasks/sudo.yml
   - include: $tasks/openvpn_client.yml
-    only_if: "'$env' != 'staging'"
+    when: env != "staging"
   - include: $tasks/fedmsg_base.yml
   - include: $tasks/apache.yml
   - include: $tasks/mod_wsgi.yml

roles/badges-backend/tasks/main.yml

@@ -63,7 +63,7 @@
     mode=700
     owner=fedmsg
     group=fedmsg
-  only_if: "'$env' != 'staging'"
+  when: env != "staging"
   tags:
   - config
   - cron
@@ -74,7 +74,7 @@
     path=$item
     mode=755
     owner=root
-  only_if: "'$env' != 'staging'"
+  when: env != "staging"
   with_items:
   - /usr/share/badges/cronjobs/
   - /etc/cron.d/
@@ -88,7 +88,7 @@
     dest=/usr/share/badges/cronjobs/$item
     owner=fedmsg
     mode=744
-  only_if: "'$env' != 'staging'"
+  when: env != "staging"
   with_items:
   - award-oldschool-badges
   - award-libravatar-badge
@@ -102,7 +102,7 @@
     dest=/etc/cron.d/$item
     owner=root
     mode=644
-  only_if: "'$env' != 'staging'"
+  when: env != "staging"
   with_items:
   - award-oldschool-badges
   - award-libravatar-badge