Infrastructure/ansible
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity Actions

people: Do not try to chown the file, the cron already runs as apache

Browse source 
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
This commit is contained in:
Pierre-Yves Chibon 2021-04-07 21:39:17 +02:00 • committed by pingou
parent 692647ed86
commit 26ca32d11d
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
roles/people/files/make-people-page.py
View file

@ -207,11 +207,16 @@ out_file_grp = grp.getgrnam("web").gr_gid
with open(out_file, "w", encoding="utf-8") as handle: with open(out_file, "w", encoding="utf-8") as handle:
handle.write(page_output) handle.write(page_output)
# keep current owner uid # The code below was present originally, however the cron job is ran under the
st = out_file.stat() # `apache` user so it is not clear what this was meant to do.
out_file_uid = st.st_uid # This is being kept here for convenience in case we need to re-activate this
# code, down the line this should just be removed.
# keep current owner uid
#st = out_file.stat()
#out_file_uid = st.st_uid
#
# give write permissions to group # give write permissions to group
out_file.chmod(st.st_mode | stat.S_IWGRP) #out_file.chmod(st.st_mode | stat.S_IWGRP)
# chown out file to group # chown out file to group
os.chown(out_file, out_file_uid, out_file_grp) #os.chown(out_file, out_file_uid, out_file_grp)