Rearrange some tasks

We have a gitolite/check_fedmsg_hooks role, which installs a script and
schedules it.

Turns out, this script does more than just checking the fedmsg hooks,
depending on the command-line arguments used when running it.

As such, it makes sense to separate it out into its own role, and make
the gitolite/check_fedmsg_hooks role (and any other one using the
script) depend on it.

For example, this script is used for Fedora Hosted (still in Puppet),
and will soon be used for a new distgit hook check.

roles/git/checks/tasks/main.yml

@@ -0,0 +1,14 @@
+---
+# tasklist for setting up a git check script
+#
+# The script implements various checks (even though it is named check-perms,
+# it checks more than perms), and various other roles can then use it in cron
+# jobs, triggered by fedmsg, etc...
+
+- name: install the needed packages
+  yum: pkg=git state=present
+
+- name: install the script
+  copy: >
+    src=check-perms.py dest=/usr/local/bin/git-check-perms
+    owner=root group=root mode=0755

roles/gitolite/check_fedmsg_hooks/meta/main.yml

@@ -0,0 +1,3 @@
+---
+dependencies:
+- { role: git/checks }

roles/gitolite/check_fedmsg_hooks/tasks/main.yml

@@ -1,15 +1,7 @@
 ---
 # tasklist for setting up Gitolite Fedmsg checks
 
-- name: install the needed packages
+- name: schedule check execution
-  yum: pkg=git state=present
-
-- name: install the script
-  copy: >
-    src=check-perms.py dest=/usr/local/bin/git-check-perms
-    owner=root group=root mode=0755
-
-- name: install the cron job for the script
   cron: >
     name="git-check-perms" cron_file="ansible-git-check-perms"
     minute=10 hour=0 weekday=3