From 1007e7f3d5fccbe0d4e1f85db0855fbbc469566e Mon Sep 17 00:00:00 2001
From: Patrick Uiterwijk <puiterwijk@redhat.com>
Date: Fri, 18 May 2018 12:02:02 +0200
Subject: [PATCH] Write SAR output while running, so we do not accumulate
 everything in memory

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
---
 playbooks/manual/gdpr/sar.yml | 33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)

diff --git a/playbooks/manual/gdpr/sar.yml b/playbooks/manual/gdpr/sar.yml
index 1c46fe5b3e..aeb787cb1c 100644
--- a/playbooks/manual/gdpr/sar.yml
+++ b/playbooks/manual/gdpr/sar.yml
@@ -2,6 +2,18 @@
 #
 # Please read http://fedora-infra-docs.readthedocs.io/en/latest/sysadmin-guide/sops/gdpr_sar.html
 # for information about how to use this playbook and how to integration applications with it.
+- name: Create the archive location
+  hosts: localhost
+  tasks:
+    - name: "Create the archive"
+      block:
+        # Create a safe place to store the files.
+        - command: "mktemp -d"
+          register: sar_tmp_dir
+        # Let's make this a more conveniently expressed variable.
+        - set_fact:
+            sar_tmp_dir: "{{ sar_tmp_dir['stdout'] }}"
+
 - name: Gather SAR data
   hosts: sar
   tasks:
@@ -15,23 +27,22 @@
     # Let's make this a more conveniently expressed variable.
     - set_fact:
         sar_data: "{{ sar_data['stdout'] }}"
+    # Store the result on disk
+    - copy:
+        content: "{{ hostvars[item]['sar_data'] }}"
+        dest: "{{ sar_tmp_dir }}/{{ hostvars[item]['sar_output_file'] }}"
+      loop: "{{ groups['sar'] }}"
+      delegate_to: localhost
+      delegate_facts: true
+    # Remove the variable from memory
+    - command: "/usr/bin/true"
+      register: sar_data
 
 - name: Create the archive
   hosts: localhost
   tasks:
     - name: "Create the archive"
       block:
-        # Create a safe place to store the files.
-        - command: "mktemp -d"
-          register: sar_tmp_dir
-        # Let's make this a more conveniently expressed variable.
-        - set_fact:
-            sar_tmp_dir: "{{ sar_tmp_dir['stdout'] }}"
-        # Write files from each service into our protected folder.
-        - copy:
-            content: "{{ hostvars[item]['sar_data'] }}"
-            dest: "{{ sar_tmp_dir }}/{{ hostvars[item]['sar_output_file'] }}"
-          loop: "{{ groups['sar'] }}"
         # Generate a private tarball of the files from each service.
         - shell: "umask 0077 && tar --transform \"s:^:{{ sar_fas_user }}_{{ sar_email }}/:\" -czf {{ sar_tmp_dir }}/{{ sar_fas_user }}_{{ sar_email }}.tar.gz *"
           args: