Docs/quick-docs
1
0
Fork 0
Code Issues 48 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Technical review on getting-started-with-apache-http-server #303

Merged
ryanlerch merged 29 commits from technical_review into master 2021-01-27 00:37:27 +00:00
Conversation 14 Commits 29 Files changed 19 +178 -141
copperi commented 2020-11-15 05:19:24 +00:00
Contributor
Copy link

Technical review completed and is now accurate.

Added sudo to lines where needed
Changed "apachectl reload" to "sudo systemctl reload httpd.service"
Added / to the end of /etc/httpd/conf.d
Removed "needs review" section.

Technical review completed and is now accurate. Added sudo to lines where needed Changed "apachectl reload" to "sudo systemctl reload httpd.service" Added / to the end of /etc/httpd/conf.d Removed "needs review" section.
copperi commented 2020-11-16 15:41:05 +00:00
Author
Contributor
Copy link

2 new commits added

  • removed needs review section
  • Technical review done, fixed a typo
**2 new commits added** * ``removed needs review section`` * ``Technical review done, fixed a typo``
copperi commented 2020-11-16 15:45:43 +00:00
Author
Contributor
Copy link

Added a technical review on "adding-or-removing-software-repositories-in-fedora"

Added a technical review on "adding-or-removing-software-repositories-in-fedora"
copperi commented 2020-11-24 15:42:13 +00:00
Author
Contributor
Copy link

rebased onto 7973ecb3fe9f54eff40a02c3d75c3a170a6e0d1b

rebased onto 7973ecb3fe9f54eff40a02c3d75c3a170a6e0d1b
copperi commented 2020-11-24 15:47:41 +00:00
Author
Contributor
Copy link

rebased onto ea88eb7163000960b94d1bcdfafe42dd207a3e30

rebased onto ea88eb7163000960b94d1bcdfafe42dd207a3e30
copperi commented 2021-01-08 17:19:37 +00:00
Author
Contributor
Copy link

rebased onto 9c5a05f126066b9372cd921f096bbc6da374888c

rebased onto 9c5a05f126066b9372cd921f096bbc6da374888c
copperi commented 2021-01-09 14:37:04 +00:00
Author
Contributor
Copy link

@mattdm Who should handle this PR ?

@mattdm Who should handle this PR ?
pbokoc commented 2021-01-25 23:56:27 +00:00
Contributor
Copy link

rebased onto fb31f63a35

rebased onto fb31f63a35ab82948c3db327c1536d1ba919197d
pbokoc commented 2021-01-26 00:02:23 +00:00
Contributor
Copy link

(Fixes #206)

Hi @copperi, I have a small change request: Can you remove the # and $ prompts from all lines with command examples? We used to do that before to indicate whether you need to be root or not for each command, but a while ago Fedora enabled sudo by default so we just add sudo when it's needed.

(Fixes #206) Hi @copperi, I have a small change request: Can you remove the `#` and `$` prompts from all lines with command examples? We used to do that before to indicate whether you need to be root or not for each command, but a while ago Fedora enabled sudo by default so we just add `sudo` when it's needed.
copperi commented 2021-01-26 05:29:40 +00:00
Author
Contributor
Copy link

6 new commits added

  • Fix conflicts
  • Removed the # and $ prompts from command examples
  • deleted an extra file
  • Technical review on getting-started-with-apache-http-server
  • Added missing sudo statement.
  • Did a technical review and corrected commands as needed. File is now accurate.
**6 new commits added** * ``Fix conflicts`` * ``Removed the # and $ prompts from command examples`` * ``deleted an extra file`` * ``Technical review on getting-started-with-apache-http-server`` * ``Added missing sudo statement.`` * ``Did a technical review and corrected commands as needed. File is now accurate.``
copperi commented 2021-01-26 05:33:46 +00:00
Author
Contributor
Copy link

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild
copperi commented 2021-01-26 05:34:17 +00:00
Author
Contributor
Copy link

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild
copperi commented 2021-01-26 05:36:01 +00:00
Author
Contributor
Copy link

Hi @ pbokoc, removed # and $ prompts as requested.

Hi @ pbokoc, removed # and $ prompts as requested.
pbokoc commented 2021-01-27 00:37:18 +00:00
Contributor
Copy link

Looks good, thank you!

Looks good, thank you!
pbokoc commented 2021-01-27 00:37:28 +00:00
Contributor
Copy link

Pull-Request has been merged by pbokoc

Pull-Request has been merged by pbokoc
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
Closed As
complete
Closed with the reason of complete

  
Closed As
duplicate
Closed with the reason of duplicate

  
Closed As
insufficient data
Closed with the reason of insufficient data

  
Closed As
moved
Closed with the reason of moved

  
Closed As
not possible
Closed with the reason of not possible

  
Closed As
out of scope
Closed with the reason of out of scope

  
Closed As
stale
Closed with the reason of stale

  
good first issue

Good for newcomers (if you want to get involved, try working on one of these!)

  
help wanted

Anyone is welcome to help us with this!

  
improvement

Improves on something that already exists

  
needs changes

Needs changes or fixes before closing

  
needs committer review

Needs review by a person with committer privileges or a subject-matter expert (SME)

  
needs info

Extra attention or information needed

  
new change

Adds new capabilities or functionality

  
Priority
awaiting triage
Priority of awaiting triage

  
Priority
needs review
Priority of needs review

  
Priority
next meeting
Priority of next meeting

  
Priority
waiting on assignee
Priority of waiting on assignee

  
Priority
waiting on external
Priority of waiting on external

No labels
bug
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
improvement
needs changes
needs committer review
needs info
new change
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Docs/quick-docs#303
No description provided.
Delete branch "technical_review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?