From 3cc4533ad1ba4ddff4ff062351319e15c60d64a1 Mon Sep 17 00:00:00 2001 From: Huzaifa Sidhpurwala Date: Wed, 22 Sep 2021 10:16:00 +0530 Subject: [PATCH] more broken link fixes --- modules/ROOT/pages/tasks/Tasks-Cryptography.adoc | 2 +- modules/ROOT/pages/tasks/Tasks-File_System.adoc | 2 +- modules/ROOT/pages/tasks/Tasks-Library_Design.adoc | 2 +- modules/ROOT/pages/tasks/Tasks-Processes.adoc | 2 +- modules/ROOT/pages/tasks/Tasks-Serialization.adoc | 4 ++-- modules/ROOT/pages/tasks/Tasks-Temporary_Files.adoc | 8 ++++---- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/ROOT/pages/tasks/Tasks-Cryptography.adoc b/modules/ROOT/pages/tasks/Tasks-Cryptography.adoc index 7153219..6ba4395 100644 --- a/modules/ROOT/pages/tasks/Tasks-Cryptography.adoc +++ b/modules/ROOT/pages/tasks/Tasks-Cryptography.adoc @@ -50,7 +50,7 @@ but strongly discouraged These primitives are difficult to use in a secure way. Custom implementation of security protocols should be avoided. For protecting confidentiality and integrity of network -transmissions, TLS should be used (<>). +transmissions, TLS should be used (xref:../features/Features-TLS.adoc#chap-Defensive_Coding-TLS[Transport Layer Security]). In particular, when using AES in CBC mode, it is necessary to add integrity checking by other means, preferably using diff --git a/modules/ROOT/pages/tasks/Tasks-File_System.adoc b/modules/ROOT/pages/tasks/Tasks-File_System.adoc index 8eebaec..12e24e8 100644 --- a/modules/ROOT/pages/tasks/Tasks-File_System.adoc +++ b/modules/ROOT/pages/tasks/Tasks-File_System.adoc @@ -9,7 +9,7 @@ In this chapter, we discuss general file system manipulation, with a focus on access files and directories to which an other, potentially untrusted user has write access. -Temporary files are covered in their own chapter, <>. +Temporary files are covered in their own chapter, xref:../tasks/Tasks-Temporary_Files.adoc#chap-Defensive_Coding-Tasks-Temporary_Files[Temporary Files]. [[sect-Defensive_Coding-Tasks-File_System-Unowned]] == Working with Files and Directories Owned by Other Users diff --git a/modules/ROOT/pages/tasks/Tasks-Library_Design.adoc b/modules/ROOT/pages/tasks/Tasks-Library_Design.adoc index 20b5503..7769859 100644 --- a/modules/ROOT/pages/tasks/Tasks-Library_Design.adoc +++ b/modules/ROOT/pages/tasks/Tasks-Library_Design.adoc @@ -126,7 +126,7 @@ Several attributes are global and affect all code in the process, not just the library that manipulates them. * environment variables -(see <>) +(see xref:../tasks/Tasks-Processes.adoc#sect-Defensive_Coding-Tasks-secure_getenv[Accessing Environment Variables]) * umask diff --git a/modules/ROOT/pages/tasks/Tasks-Processes.adoc b/modules/ROOT/pages/tasks/Tasks-Processes.adoc index 6c98468..b5bdcd6 100644 --- a/modules/ROOT/pages/tasks/Tasks-Processes.adoc +++ b/modules/ROOT/pages/tasks/Tasks-Processes.adoc @@ -10,7 +10,7 @@ include::{partialsdir}/entities.adoc[] This section describes how to create new child processes in a safe manner. In addition to the concerns addressed below, there -is the possibility of file descriptor leaks, see <>. +is the possibility of file descriptor leaks, see xref:../tasks/Tasks-Descriptors.adoc#sect-Defensive_Coding-Tasks-Descriptors-Child_Processes[Preventing File Descriptor Leaks to Child Processes]. === Obtaining the Program Path and the Command-line Template diff --git a/modules/ROOT/pages/tasks/Tasks-Serialization.adoc b/modules/ROOT/pages/tasks/Tasks-Serialization.adoc index 7e481e9..4c52a9d 100644 --- a/modules/ROOT/pages/tasks/Tasks-Serialization.adoc +++ b/modules/ROOT/pages/tasks/Tasks-Serialization.adoc @@ -13,7 +13,7 @@ robustly in languages which are not memory-safe. [[sect-Defensive_Coding-Tasks-Serialization-Decoders]] == Recommendations for Manually-written Decoders -For C and C++, the advice in <> applies. In +For C and C++, the advice in xref:../programming-languages/C-Language.adoc#sect-Defensive_Coding-C-Pointers[Recommendations for Pointers and Array Handling] applies. In addition, avoid non-character pointers directly into input buffers. Pointer misalignment causes crashes on some architectures. @@ -107,7 +107,7 @@ reject fragments which are inconsistent. fragments against the unfragmented PDU length (if they are present). Check that the last byte in the fragment does not lie after the end of the unfragmented PDU. Avoid integer -overflows in these computations (see <>). +overflows in these computations (see xref:../programming-languages/C-Language.adoc#sect-Defensive_Coding-C-Arithmetic[Recommendations for Integer Arithmetic]). [[sect-Defensive_Coding-Tasks-Serialization-Fragmentation-ID]] === Fragment IDs diff --git a/modules/ROOT/pages/tasks/Tasks-Temporary_Files.adoc b/modules/ROOT/pages/tasks/Tasks-Temporary_Files.adoc index 6ac3f6b..99ce233 100644 --- a/modules/ROOT/pages/tasks/Tasks-Temporary_Files.adoc +++ b/modules/ROOT/pages/tasks/Tasks-Temporary_Files.adoc @@ -8,13 +8,13 @@ In this chapter, we describe how to create temporary files and directories, how to remove them, and how to work with programs which do not create files in ways that are safe with a shared directory for temporary files. General file system manipulation -is treated in a separate chapter, <>. +is treated in a separate chapter, xref:../tasks/Tasks-File_System.adoc#chap-Defensive_Coding-Tasks-File_System[File System Manipulation]. Secure creation of temporary files has four different aspects. * The location of the directory for temporary files must be obtained in a secure manner (that is, untrusted environment -variables must be ignored, see <>). +variables must be ignored, see xref:../tasks/Tasks-Processes.adoc#sect-Defensive_Coding-Tasks-secure_getenv[Accessing Environment Variables). * A new file must be created. Reusing an existing file must be avoided (the `/tmp` race @@ -71,7 +71,7 @@ temporary file. You should specify the to subprocesses. (Applications which do not use multiple threads can also use `mkstemp`, but libraries should use `mkostemp`.) For determining the -directory part of the file name pattern, see <>. +directory part of the file name pattern, see <> The file is not removed automatically. It is not safe to rename or delete the file before processing, or transform the name in @@ -151,7 +151,7 @@ the [option]`-rf` and [option]`--` options. There are two ways to make a function or program which excepts a file name safe for use with temporary files. See -<>, +xref:../tasks/Tasks-Processes.adoc#sect-Defensive_Coding-Tasks-Processes-Creation[Creating Safe Processes] for details on subprocess creation. * Create a temporary directory and place the file there. If