From 52329a4c460ca531aa37f582385201c4dee2008d Mon Sep 17 00:00:00 2001 From: Nils Philippsen Date: Mon, 8 Jul 2024 18:46:29 +0200 Subject: [PATCH] toddlers: Fix distgit_commit_processor templates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These are passed to str.format() which confusingly doesn’t expect quotes around dictionary keys and adds them to the looked up key string, yay! Related: #183 Signed-off-by: Nils Philippsen --- .../openshift-apps/poddlers/templates/fedora-messaging.toml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/roles/openshift-apps/poddlers/templates/fedora-messaging.toml b/roles/openshift-apps/poddlers/templates/fedora-messaging.toml index 7f2c695d12..f831842188 100644 --- a/roles/openshift-apps/poddlers/templates/fedora-messaging.toml +++ b/roles/openshift-apps/poddlers/templates/fedora-messaging.toml @@ -303,13 +303,14 @@ notify_emails = [ [consumer_config.distgit_commit_processor] mail_from = "notifications@{{ env_prefix }}fedoraproject.org" mail_to = "scm-commits@lists.{{ env_prefix }}fedoraproject.org" +# The templates are passed to str.format() => no quotes in dictionary keys! # This is the default subject # mail_subject_tmpl = "{message.summary}" -mail_content_tmpl = """Notification time stamped {headers['sent-at']} +mail_content_tmpl = """Notification time stamped {headers[sent-at]} {message} - {commit['url']} + {commit[url]} """